javascript - jQuery code refactoring help needed -


an update before, here's i'm dealing with:

<body> <div class="header"> <img class="imglogo" src="img/vegtablelogo.jpg"> </div> <div id="thumbscontainer">   <div class="thumb" id="carrotthumb"> <img id="showcarrot" class="imgthumb" src="img/carot.jpg" onclick=setupveg("showcarrot", "carrotbig") /> </div>   <div class="hidden" id="carrotbig"> <img class="imgbig" src="img/carot.jpg" /> </div>   <div class="thumb" id="brocthumb"> <img id="showbroc" class="imgthumb" src="img/brocoli.jpg" onclick=setupveg("showbroc", "brocbig") /> </div>   <div class="hidden" id="brocbig"> <img class="imgbig" src="img/brocoli.jpg" /> </div> </div> <!-- end thumbs container -->   <script> var active = "";  function setupveg(thumbveg, hiddenveg) {     $("#" + thumbveg).click(function() {         if (active != hiddenveg) {             $("div.hidden").hide("fast");             $("#" + hiddenveg).show("fast", function() {});             active = hiddenveg;         }         else {             $("div.hidden").hide("fast");             active="";         }     }); }  $("div.hidden").click(function () {     $("div.hidden").hide("fast");     isanybig=false; });  </script> </body>

this code not working unfortunately. have borrowed suggested solution below.

would nice if did work! suggestions, welcome.

i don't think need of flags or if conditions really. think logic is:

  • toggle carrotbig whenever showcarrot clicked.
  • hide div.hidden whenever showcarrot clicked.

so need is:

$("#showcarrot").click(function () {    $("#carrotbig").toggle("fast");    $("#div.hidden").hide(); });

.toggle handle 1 of flags (iscarrotbig) , .hide() won't if div.hidden hidden, takes care of isanybig flag.

now.. let's make work broc well...

function setupvegetable(showid, toggleid) {    $("#" + showid).click(function () {       $("#" + toggleid).toggle("fast");       $("#div.hidden").hide();    }); }  setupvegetable("showcarrot", "carrotbig"); setupvegetable("showbroc", "brocbig");

if you're interested, can refactor further don't need supply ids each of vegetables. i'll need see html markup though.


Comments

Post a Comment

Popular posts from this blog

asp.net - repeatedly call AddImageUrl(url) to assemble pdf document -

i'm using abcpdf , i'm curious if can recursively call addimageurl() function assemble pdf document compile multiple urls? something like: int pagecount = 0; int theid = thedoc.addimageurl("http://stackoverflow.com/search?q=abcpdf+footer+page+x+out+of+", true, 0, true); //assemble document while (thedoc.chainable(theid)) { thedoc.page = thedoc.addpage(); theid = thedoc.addimagetochain(theid); } pagecount = thedoc.pagecount; console.writeline("1 document page count:" + pagecount); //flatten document (int = 1; <= pagecount; i++) { thedoc.pagenumber = i; thedoc.flatten(); } //now try again theid = thedoc.addimageurl("http://stackoverflow.com/questions/1980890/pdf-report-generation", true, 0, true); //assemble document while (thedoc.chainable(theid)) { thedoc.page = thedoc.addpage(); theid = thedoc.addimagetoc...
Read more

java - Android recognize cell phone with keyboard or not? -

in android app, want detect user's device if device has keyboard(like motorola milestone) , show corresponding user interface. guys know how that? ! regards justicepenny http://developer.android.com/reference/android/content/res/configuration.html public int keyboard the kind of keyboard attached device. 1 of: keyboard_nokeys, keyboard_qwerty, keyboard_12key. that's it!
Read more

iphone - How would you achieve a LED Scrolling effect? -

how achieve led scrolling effect example below? led sign - led ticker emulator iphone , ipad http://img.skitch.com/20101201-rsfh4p1bajb1wp94k466pdpiuj.preview.jpg sometimes remunerates comment in other posts :) have put code you, should implement font '8pin matrix' realistic feeling. uilabel *label; - (void)viewdidload { [super viewdidload]; label = [[uilabel alloc]initwithframe:cgrectmake(10, 50, 300, 20)]; label.font = [uifont fontwithname:@"courier-bold" size:16.0]; label.backgroundcolor = [uicolor blackcolor]; label.textcolor = [uicolor greencolor]; label.linebreakmode = uilinebreakmodecharacterwrap; // otherwise "…" label.text = @"this led text scrolled "; // blanks space between [self.view addsubview:label]; [nstimer scheduledtimerwithtimeinterval:0.12f target:self selector:@selector(scrolllabel) use...
Read more