Software Code Review -


i need code review group's project , have code review on group project. have never done code review, guys know can find example know has in it?

there no 1 way. work, use crucible. amounts commenting on code. things out for:

  • ensure code meets standards (set department perhaps)
  • proper formatting
  • syntax errors (these worst - person must, @ least, have compiled code)
  • logical errors (actual errors in logical flow of code)
  • risky/fragile/error-prone code
  • code hard maintain
  • software antipatterns
  • bad practices/code smells
  • improper naming of variables/methods (self-documenting code important; make sure name methods , variables properly)
  • race conditions (in multithreaded code)
  • buffer overflows
  • infinite recursion
  • edge cases have not been handled

there many more; things "don't right". when performing code review:

  • criticize code, not person.
  • don't combative or brusque instead of saying *"you should doing x, y, z! you're doing (a, b, c) not right!" try saying "why don't try doing x, y, z? a, b, c doesn't right here". posing question makes less aggressive/combative.
  • a code review supposed educational experience. aim other person learn mistakes (if any); code review great place knowledge transfer.

Comments

Post a Comment

Popular posts from this blog

asp.net - repeatedly call AddImageUrl(url) to assemble pdf document -

i'm using abcpdf , i'm curious if can recursively call addimageurl() function assemble pdf document compile multiple urls? something like: int pagecount = 0; int theid = thedoc.addimageurl("http://stackoverflow.com/search?q=abcpdf+footer+page+x+out+of+", true, 0, true); //assemble document while (thedoc.chainable(theid)) { thedoc.page = thedoc.addpage(); theid = thedoc.addimagetochain(theid); } pagecount = thedoc.pagecount; console.writeline("1 document page count:" + pagecount); //flatten document (int = 1; <= pagecount; i++) { thedoc.pagenumber = i; thedoc.flatten(); } //now try again theid = thedoc.addimageurl("http://stackoverflow.com/questions/1980890/pdf-report-generation", true, 0, true); //assemble document while (thedoc.chainable(theid)) { thedoc.page = thedoc.addpage(); theid = thedoc.addimagetoc...
Read more

java - Android recognize cell phone with keyboard or not? -

in android app, want detect user's device if device has keyboard(like motorola milestone) , show corresponding user interface. guys know how that? ! regards justicepenny http://developer.android.com/reference/android/content/res/configuration.html public int keyboard the kind of keyboard attached device. 1 of: keyboard_nokeys, keyboard_qwerty, keyboard_12key. that's it!
Read more

iphone - How would you achieve a LED Scrolling effect? -

how achieve led scrolling effect example below? led sign - led ticker emulator iphone , ipad http://img.skitch.com/20101201-rsfh4p1bajb1wp94k466pdpiuj.preview.jpg sometimes remunerates comment in other posts :) have put code you, should implement font '8pin matrix' realistic feeling. uilabel *label; - (void)viewdidload { [super viewdidload]; label = [[uilabel alloc]initwithframe:cgrectmake(10, 50, 300, 20)]; label.font = [uifont fontwithname:@"courier-bold" size:16.0]; label.backgroundcolor = [uicolor blackcolor]; label.textcolor = [uicolor greencolor]; label.linebreakmode = uilinebreakmodecharacterwrap; // otherwise "…" label.text = @"this led text scrolled "; // blanks space between [self.view addsubview:label]; [nstimer scheduledtimerwithtimeinterval:0.12f target:self selector:@selector(scrolllabel) use...
Read more